-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new google_project_service
resource for fine-grained service control.
#668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor ID quibble, but otherwise looks good.
return fmt.Errorf("Error enabling service: %s", err) | ||
} | ||
|
||
d.SetId(srv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include the project in this, so multiple projects can enable the same service within the same Terraform state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Done.
👍 x10 I was about to create a PR about it since we were having a lot of inconsistent states when enabling some complex APIs (like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Just to confirm my understanding...I want to use appengine flex in my project, so in order to enable that API I need to "do a little dance" and rely on |
For your use case, it is up to you. Do you want to make sure only the APIs specified in your config are enabled? If so, use I hope this helps :) |
…ntrol. (hashicorp#668) * add new project service resource; add retry logic for enable/disable * docs for google_project_service * add project into the id
Signed-off-by: Modular Magician <[email protected]>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #482.
Potential fix for #5 and #596.
Also adds retry logic for enabling/disabling because the tests were being too flaky without it.