Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to google_project_iam_custom_role docs to include id field #6089

Closed
upodroid opened this issue Apr 10, 2020 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#3370, #6111 or hashicorp/terraform-provider-google-beta#1951
Assignees
Milestone

Comments

@upodroid
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Can we update the docs at https://www.terraform.io/docs/providers/google/r/google_project_iam_custom_role.html to mention that the id attribute is available so you can use with google_project_iam_binding

New or Affected Resource(s)

  • google_project_iam_custom_role

Terraform Configuration


resource "google_project_iam_binding" "bq_scheduler" {
  project = var.project_id
  role    = google_project_iam_custom_role.bq_scheduler.id

  members = [
    "serviceAccount:${google_service_account.bq_scheduler.email}"
  ]
}

resource "google_project_iam_custom_role" "bq_scheduler" {
  role_id     = "bigquery.scheduledUser"
  title       = "Bigquery Scheduled User"
  description = "A Custom Role to allow service accounts to run scheduled BQ queries"
  permissions = ["bigquery.datasets.get", "bigquery.jobs.create", "bigquery.transfers.get", "bigquery.tables.getData", "bigquery.tables.updateData", "bigquery.tables.updateData"]
}

resource "google_service_account" "bq_scheduler" {
  account_id   = "bq-scheduler"
  display_name = "BigQuery Scheduler"
}

Using role_id only causes errors because Google expects projects/project_id/roles/role_id but that is already there with the attribute id.

@ghost
Copy link

ghost commented May 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.