add master_version to container cluster

[danawillow]

Fixes #492

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_withVersion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_withVersion -timeout 120m
=== RUN   TestAccContainerCluster_withVersion
--- PASS: TestAccContainerCluster_withVersion (367.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	367.200s

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_updateVersion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_updateVersion -timeout 120m
=== RUN   TestAccContainerCluster_updateVersion
--- PASS: TestAccContainerCluster_updateVersion (871.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	872.204s

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_basic -timeout 120m
=== RUN   TestAccContainerCluster_basic
--- PASS: TestAccContainerCluster_basic (379.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	379.704s

I also tested that existing users won't have issues by creating a cluster without a specific version on an older build (creating it with a specific version is what this is fixing), then updated my build and ran terraform plan.

[Stelminator]

Thanks for fixing this so quickly! :-)

[Stono]

@danawillow what version of TF will this be in? I'm struggling to correlate master vs releases :D

[danawillow]

@Stono it'll be in the next release version. According to https://github.com/terraform-providers/terraform-provider-google/blob/master/CHANGELOG.md that'll be 1.0.2 but I won't know until we release it whether that's the number it stays with or whether it'll go up to 1.1.0 or something like that. You can always check the changelog though to see whether it's been released or not though :)

[Stono]

Ah cool, keeping with semver the minor bump makes sense Do you have a rough ETA as this is causing problems for multiple product teams! On 10 Oct 2017 21:23, "Dana Hoffman" <[email protected]> wrote: @Stono <https://github.com/stono> it'll be in the next release version. According to https://github.com/terraform-providers/terraform-provider- google/blob/master/CHANGELOG.md that'll be 1.0.2 but I won't know until we release it whether that's the number it stays with or whether it'll go up to 1.1.0 or something like that. You can always check the changelog though to see whether it's been released or not though :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#538 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABaviUGiiXkJvCQlvVXyjmfpMZQlonosks5sq9JDgaJpZM4PvwgG> .

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!