Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy network_interface attributes back to state on resourceComputeInstanceRead(). (Fixes #519) #536

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Copy network_interface attributes back to state on resourceComputeInstanceRead(). (Fixes #519) #536

merged 1 commit into from
Oct 11, 2017

Conversation

PeterMilley
Copy link
Contributor

@PeterMilley PeterMilley commented Oct 5, 2017 •
edited
Loading

Fixes #519.

Added an acceptance test for coverage.

@PeterMilley PeterMilley changed the title Copy network_interface attributes back to state on resourceComputeInstanceRead(). Copy network_interface attributes back to state on resourceComputeInstanceRead(). (Fixes #519) Oct 5, 2017
@rosbo rosbo requested a review from paddycarver October 5, 2017 22:07
@radeksimko radeksimko added the bug label Oct 8, 2017
@briffle briffle mentioned this pull request Oct 10, 2017
Closed
genevieve pushed a commit to vmware-archive/terraforming-gcp that referenced this pull request Oct 10, 2017
@mcwumbly
Pin google provider to 0.1.3
ae05cb8 
- There is a problem with 1.0+ that we see when trying to create the dns
entry for the opsman instance.

Related PR: hashicorp/terraform-provider-google#536

Signed-off-by: Dave McClure <[email protected]>
@PeterMilley
Copy link
Contributor Author

@paddycarver, gentle bump?

@kszarek
Copy link

kszarek commented Oct 11, 2017

Is there any news on this one?

@rosbo
Copy link
Contributor

rosbo commented Oct 11, 2017

@paddycarver The d.Set("network_interface", networkInterfaces) line was deleted by mistake when the deprecated resources were deleted prior to the 1.0.0 release: f2f276e#diff-6ebc1a840e42235a51a46d537f17ddaa

@rosbo rosbo mentioned this pull request Oct 11, 2017
Closed
@rosbo
Copy link
Contributor

rosbo commented Oct 11, 2017 

=== RUN   TestAccComputeInstance_GenerateIP
--- PASS: TestAccComputeInstance_GenerateIP (181.66s)

Thank you Peter for the fix! It will be included in the next release of the google provider.

@rosbo rosbo merged commit fe01f7f into hashicorp:master Oct 11, 2017
@anas-aso
Copy link

@rosbo thanks for merging this. any idea when will be the next release ? this is a kind of blocker to us.

@christopher-demarco
Copy link

Yes please—what is the ETA for release?
Critical blocker for high-profile public demo on 30 Oct :-(

@genevieve
Copy link

@christopher-demarco You can pin the google provider version in your template to version = "0.1.3" until they merge the PR for the fix.

@christopher-demarco
Copy link

Where is the "thank-you-internet-beer-for-you" emoji?

@rosbo
Copy link
Contributor

rosbo commented Oct 11, 2017

We definitely want to get a release out with this fix ASAP. I can't share an ETA until I have spoken with @paddycarver. Stay tuned.

@paddycarver
Copy link
Contributor

Apologies all, busy day. Thanks @rosbo for the merge. We've got one last bug we're trying to fix, and are anticipating a release rather soon. I can't promise dates, but we're aware of the urgency of getting a bugfix release out for this. Sorry for the issues.

@PeterMilley PeterMilley deleted the networks branch October 12, 2017 02:53
@christopher-demarco
Copy link

Thanks folks, it's super-appreciated. FLOSS devs are the best!

@pydevops
Copy link

Verified the network_interface.0.address works now after the 1.1.0 released

@anas-aso anas-aso mentioned this pull request Oct 13, 2017
Closed
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
@PeterMilley
Copy network_interface attributes to Terraform state. (hashicorp#536)
78cedd8
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
@PeterMilley @rosbo
Copy network_interface attributes to Terraform state. (hashicorp#536)
1cf09ff
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@modular-magician @rileykarson
Fix the project metadata test in CI + fix new linter errors (hashicor…
f716249 
…p#536)

<!-- This change is generated by MagicModules. -->
/cc @rileykarson
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver Awaiting requested review from paddycarver

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compute instance IP addresses are not detected
9 participants
@PeterMilley @kszarek @rosbo @anas-aso @christopher-demarco @genevieve @paddycarver @pydevops @radeksimko