Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google_container_cluster should allow disabling of KubernetesDashboard addon #433

Closed
calind opened this issue Sep 14, 2017 · 3 comments
Closed

google_container_cluster should allow disabling of KubernetesDashboard addon #433

calind opened this issue Sep 14, 2017 · 3 comments
Assignees
@selmanj
Labels
enhancement

Comments

@calind
Copy link

calind commented Sep 14, 2017

Currently the google_container_cluster allows enabling/disabling of HorizontalPodAutoscaling and HttpLoadBalancing addons. Since https://cloud.google.com/container-engine/release-notes#july_25_2017 it's allowed to enable/disable the KubernetesDashboard addon as well.
@selmanj selmanj mentioned this issue Sep 26, 2017
Merged
@sebglon sebglon mentioned this issue Oct 1, 2017
Closed
@sebglon
Copy link
Contributor

sebglon commented Oct 2, 2017

I have created a PR for this #505

@selmanj
Copy link
Contributor

selmanj commented Oct 3, 2017

@sebglon Thanks for your PR! Unfortunately I beat you to it with #464. Please keep them coming though!

@selmanj selmanj closed this as completed Oct 3, 2017
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
@emilymye
Merge pull request hashicorp#433 from modular-magician/codegen-pr-1381
fd2b655 
Clean up failed cluster creation
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@selmanj selmanj

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@calind @selmanj @danawillow @sebglon