Change provider package path so make build succeeds.
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with gofmt requirements... go install succeeds.
danawillow
pushed a commit
that referenced
this pull request
Jan 10, 2018
* Initial commit * Adding google_cloudfunction_function resource * Some FMT updates * Working Cloud Function Create/Delete/Get Create is limited to gs:// source now. * Fixed tests import * Terraform now is able to apply and destroy function * Fully working Basic test * Added: 1. Allowed region check 2. readTimeout helper * Found better solution for conflicting values * Adding description * Adding full basic test * dded Update functionality * Made few more optional params * Added test for Labels * Added update tests * Added storage_* members and made function source deploy from storage bucket object * Adding comments * Adding tests for PubSub * Adding tests for Bucket * Adding Data provider * Fixing bug which allowed to miss error * Amending Operation retrieval * Fixing vet errors and vendoring cloudfunctions/v1 * Fixing according to comments * Fixing according to comments round #2 * Fixing tabs to space * Fixing tabs to space and some comments #3 * Re-done update to include labels in one update with others * Adding back default values. In case of such scenario, when user creates function with some values for "timeout" or "available_memory_mb", and then disables those attributes. Terraform plan then gives: No changes. Infrastructure is up-to-date. This is an error. By adding const we would avoid this error. * Fixed MixedCase and more tabs
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
…_deprecate Deprecate container_cluster.private_cluster.
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
…_deprecate Deprecate container_cluster.private_cluster.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
$ make build ==> Checking that code complies with gofmt requirements... go install