-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force_destroy option to bigquery dataset #2986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
Just a few small things, I'm wondering what the field should be named (see inline) and we'll need to document the field + test it.
For testing, you can add it to the end of this test case if you'd like: https://github.com/terraform-providers/terraform-provider-google/blob/master/google/resource_bigquery_dataset_test.go#L183
In terms of documentation, the description of the parameter in the official docs is pretty good, so we can copy that over.
@rileykarson Added the documentation and the tests. I've excluded the field from the ImportState verification step because I don't think it's part of the import state at all, let me know if this is an incorrect assumption to make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just one more comment & a couple spacing nitpicks.
Done. Thanks so much for the quick reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution!
All that's left is on my end- I'm going to duplicate this up in to our shared code generator, Magic Modules, in order to ensure that this change gets added to google-beta
as well. Once I've done so, I'll merge this PR & your feature will be available in the next provider release.
awesome 👍 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Added the
force_destroy
option for bigquery datasets, as described in #2050.