google_compute_instance can specified the subnetwork using a self_link #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
approved these changes
Aug 3, 2017
There was a problem hiding this comment.
make testacc TEST=./google TESTARGS='-run=TestAccComputeInstance_subnet_custom'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeInstance_subnet_custom -timeout 120m
=== RUN TestAccComputeInstance_subnet_custom
--- PASS: TestAccComputeInstance_subnet_custom (118.79s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 118.929s
| Optional: true, | ||
| Computed: true, | ||
| ForceNew: true, | ||
| DiffSuppressFunc: linkDiffSuppress, |
There was a problem hiding this comment.
While you're here, want to add a ConflictsWith for subnetwork? Then we can get rid of an if statement below
This was referenced Aug 4, 2017
z1nkum
pushed a commit
to z1nkum/terraform-provider-google
that referenced
this pull request
Aug 15, 2017
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
Currently, you can only specify the
subnetworkforgoogle_compute_instanceusing thesubnetworkname. See issue #247 for more context.This adds the support for both
nameandself_linkwhen specifying thesubnetworkbringing consistency with the way other network/subnetwork fields works.I also added support for reading the network_interface fields from GCP.
cc/ @danawillow