Add Beta support for auto_healing_policies to instance group manager. #249

rileykarson · 2017-07-26T21:34:09Z

Add support for the first Beta feature, auto_healing_policies, to google_compute_instance_group_manager. Beta support was added to the resource in #234.

Part of #93.
Fixes #48.

Beta features are documented by adding a third divider to the list of fields; in addition to Required, and Optional, there is now a Beta section, where Beta fields are listed.

When users begin using Beta fields, their resources will automatically "upgrade" to Beta, and begin performing operations using Beta APIs instead of v1. If they remove the Beta fields from their resource, it will then automatically "upgrade" back to v1.

By inferring the version from the fields a user uses, we;

Don't need to perform validation that we match different schema versions in CRUD methods.
Preserve existing Terraform state files.
Allow seamless "upgrades" back to v1 as features enter GA.

We do not currently have a means of explicitly notifying users what version an operation is being performed at; I'd like to investigate means of how to show the version to users and especially whether we can surface that information at the plan phase before committing to an implementation.

I don't believe that it should be blocking for this change, as both our documentation and the GCP documentation will communicate that a feature is in Beta to users.

@catsby

…p_manager.

…d resource.

danawillow · 2017-07-27T00:43:45Z

google/resource_compute_instance_group_manager_test.go

@@ -704,6 +799,121 @@ func testAccInstanceGroupManager_separateRegions(igm1, igm2 string) string {
 	`, igm1, igm2)
 }

+func testAccInstanceGroupManager_autoHealingPolicies(template, target, igm, hck string) string {
+	return fmt.Sprintf(`
+	resource "google_compute_instance_template" "igm-basic" {


Can you align this to the left?

danawillow · 2017-07-27T16:10:37Z

Thanks! I'm fine with this once @catsby is.

rosbo · 2017-07-31T20:23:08Z

website/docs/r/compute_instance_group_manager.html.markdown

@@ -81,12 +81,24 @@ The following arguments are supported:
    instances in the group are added. Updating the target pools attribute does
    not affect existing instances.

+---
+
+* `auto_healing_policies` - (Optional, Beta) 	The autohealing policies for this managed instance


nit: extra spaces between (Optional, Beta) and The

rosbo · 2017-07-31T20:26:17Z

google/resource_compute_instance_group_manager_test.go

+
+// This test is to make sure that a single version resource can link to a versioned resource
+// without perpetual diffs because the self links mismatch.
+// Once auto_healing_policies is no longer beta, we will need to use a new field or resource.


a new field or resource for what? Not super clear.

rosbo · 2017-07-31T20:27:49Z

google/resource_compute_instance_group_manager_test.go

+		Steps: []resource.TestStep{
+			resource.TestStep{
+				Config: testAccInstanceGroupManager_autoHealingPolicies(template, target, igm, hck),
+				Check: resource.ComposeTestCheckFunc(


No need to use ComputeTestCheckFunc if you only have one check

rosbo · 2017-07-31T20:28:40Z

google/resource_compute_instance_group_manager_test.go

+		},
+	})
+
+	if len(manager.AutoHealingPolicies) != 1 {


Have you considered moving these in a TestCheckFunc?

catsby

This looks good 👍

Aside, I'd like to know what you think about adding a "Beta Features" header on the Google Provider documentation page that briefly details that some resources offer beta fields, they are considered ready for use, etc. etc. just so users know what "beta" means to the GCP provider.

If that sounds good, then I'd also request any beta field in a resource documentation then link to this definition.

This is not a blocker though, just something I'd like to hear your thoughts on doing.

catsby · 2017-08-02T15:12:17Z

Also, I apologize for being a blocker/bottleneck here. Thanks for the patience and transparency with letting me preview/vet how Google plans to introduce beta features 😄

rileykarson · 2017-08-02T17:12:00Z

@catsby: That sounds good, I'll submit the header and update this page to link to it as a followup PR.

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccInstanceGroupManager -timeout 120m
=== RUN   TestAccInstanceGroupManager_importBasic
--- PASS: TestAccInstanceGroupManager_importBasic (295.09s)
=== RUN   TestAccInstanceGroupManager_importUpdate
--- PASS: TestAccInstanceGroupManager_importUpdate (90.95s)
=== RUN   TestAccInstanceGroupManager_basic
--- PASS: TestAccInstanceGroupManager_basic (253.15s)
=== RUN   TestAccInstanceGroupManager_targetSizeZero
--- PASS: TestAccInstanceGroupManager_targetSizeZero (44.80s)
=== RUN   TestAccInstanceGroupManager_update
--- PASS: TestAccInstanceGroupManager_update (156.22s)
=== RUN   TestAccInstanceGroupManager_updateLifecycle
--- PASS: TestAccInstanceGroupManager_updateLifecycle (104.03s)
=== RUN   TestAccInstanceGroupManager_updateStrategy
--- PASS: TestAccInstanceGroupManager_updateStrategy (210.90s)
=== RUN   TestAccInstanceGroupManager_separateRegions
--- PASS: TestAccInstanceGroupManager_separateRegions (213.87s)
=== RUN   TestAccInstanceGroupManager_autoHealingPolicies
--- PASS: TestAccInstanceGroupManager_autoHealingPolicies (91.30s)
=== RUN   TestAccInstanceGroupManager_selfLinkStability
--- PASS: TestAccInstanceGroupManager_selfLinkStability (123.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	1583.506s

…hashicorp#249) * Add support for auto_healing_policies to google_compute_instance_group_manager. * Add a test for self link stability when a v1 resource uses a versioned resource. * Add a comment about what the stable self link test does. * make fmt * Fixed formatting on new tests. * Address review comments. * Fix make vet

ghost · 2020-03-31T14:06:17Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

rileykarson added 4 commits July 26, 2017 13:45

Add support for auto_healing_policies to google_compute_instance_grou…

819bb9e

…p_manager.

Add a test for self link stability when a v1 resource uses a versione…

400e3ce

…d resource.

Add a comment about what the stable self link test does.

0568152

make fmt

d517a97

rileykarson added the enhancement label Jul 26, 2017

rileykarson requested review from catsby and danawillow July 26, 2017 21:34

rileykarson mentioned this pull request Jul 26, 2017

Add Beta support & Beta feature ip_version to google_compute_global_address #250

Merged

danawillow approved these changes Jul 27, 2017

View reviewed changes

Fixed formatting on new tests.

8a53eba

rileykarson mentioned this pull request Jul 28, 2017

Add Beta support & Beta feature ip_version to google_compute_global_forwarding_rule #265

Merged

rosbo suggested changes Jul 31, 2017

View reviewed changes

Address review comments.

7636e6e

rosbo approved these changes Jul 31, 2017

View reviewed changes

Fix make vet

fcc4ccf

catsby approved these changes Aug 2, 2017

View reviewed changes

rileykarson merged commit 3877b34 into hashicorp:master Aug 2, 2017

luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019

Remove inferred zone from region on Disk import (hashicorp#249)

52bfa4d

ghost locked and limited conversation to collaborators Mar 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Beta support for auto_healing_policies to instance group manager. #249

Add Beta support for auto_healing_policies to instance group manager. #249

rileykarson commented Jul 26, 2017

danawillow Jul 27, 2017

rileykarson Jul 27, 2017

danawillow commented Jul 27, 2017

rosbo Jul 31, 2017

rileykarson Jul 31, 2017

rosbo Jul 31, 2017

rileykarson Jul 31, 2017

rosbo Jul 31, 2017

rileykarson Jul 31, 2017

rosbo Jul 31, 2017

rileykarson Jul 31, 2017

catsby left a comment •

edited

Loading

catsby commented Aug 2, 2017 •

edited

Loading

rileykarson commented Aug 2, 2017

ghost commented Mar 31, 2020

Add Beta support for auto_healing_policies to instance group manager. #249

Add Beta support for auto_healing_policies to instance group manager. #249

Conversation

rileykarson commented Jul 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danawillow commented Jul 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

catsby left a comment • edited Loading

Choose a reason for hiding this comment

catsby commented Aug 2, 2017 • edited Loading

rileykarson commented Aug 2, 2017

ghost commented Mar 31, 2020

catsby left a comment •

edited

Loading

catsby commented Aug 2, 2017 •

edited

Loading