Check for project deletion when refreshing/deleting project_service. #2090
Conversation
When reading or deleting the google_project_service resource, first retrieve the project. If it's not found, or if it's pending deletion, remove the service, as it's functionally disabled. Also, add a test to confirm the behaviour. This should resolve #1292.
There was a problem hiding this comment.
I tried to convince myself that removing it from the read was the right choice, and I had 1 scenario that I was curious about.
I created a project with an IAM service enabled. When I deleted a project, then decided to 'recover' it through the UI I noticed the IAM service was still enabled. When I re-imported the project terraform then tried to re-create the service. However to my surprise the call to create the service didn't fail. So I feel like that's an acceptable outcome for the user.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
When reading or deleting the google_project_service resource, first
retrieve the project. If it's not found, or if it's pending deletion,
remove the service, as it's functionally disabled.
Also, add a test to confirm the behaviour.
This should resolve #1292.