Add "enable_tpu" flag to google_container_cluster #1974
Conversation
| enable_tpu = true | ||
|
|
||
| initial_node_count = 1 | ||
| ip_allocation_policy { |
There was a problem hiding this comment.
Do TPUs need an ip allocation policy to be set? If not, I'd recommend removing all the extra resources/fields relevant to that and only leaving in the parts you're actually testing.
There was a problem hiding this comment.
Yes, TPUs require ip aliasing to be turned on for the cluster.
|
Whoops, sorry I let this get away for a bit. Mind rebasing/merging your changes on top of master? Also, the tests these days are a bit more explicit about how they set the |
* add enable_tpu flag * missed one * add docs * fix test * tabs * update tests to new format * formatting * formatting
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
No description provided.