Autogenerate HealthCheck resource #1941
Conversation
|
Autoscaler test changes should go away when I merge GoogleCloudPlatform/magic-modules#416 and rebase/merge, but otherwise the PR is ready for review |
modular-magician
force-pushed
the
codegen-pr-415
branch
from
7e4e1d5 to
36b47c3
Compare
modular-magician
force-pushed
the
codegen-pr-415
branch
from
36b47c3 to
24408d3
Compare
There was a problem hiding this comment.
LGTM! Tests pass for me.
$make testacc TEST=./google TESTARGS='--run="TestAccComputeHealthCheck"'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v --run="TestAccComputeHealthCheck" -timeout 120m
....
--- PASS: TestAccComputeHealthCheck_tcpAndSsl_shouldFail (0.05s)
--- PASS: TestAccComputeHealthCheck_tcp (23.62s)
--- PASS: TestAccComputeHealthCheck_ssl (23.68s)
--- PASS: TestAccComputeHealthCheck_https (23.69s)
--- PASS: TestAccComputeHealthCheck_http (23.70s)
--- PASS: TestAccComputeHealthCheck_tcp_update (35.09s)
--- PASS: TestAccComputeHealthCheck_typeTransition (69.57s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 69.752s
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
/cc @rileykarson