Don't recreate google_container_cluster on master_auth change

[alexey-medvedchikov]

I've used setMasterAuth to implement update of username and password fields. Although there's no possibility to update client_certificate_config. issue_client_certificate value and changing it will recreate cluster (no docs on that BTW. Also, I've stuck to forcing password input from a user and haven't implemented password autogeneration: not very useful feature and it will make the code more complex.

Closes #1820

[nat-henderson]

I've got pretty much the same PR in pretty much the same state on my machine. :) Looks great. The only thing left to do is add tests. Would you like to write the unit tests for yours, or should I write them for mine? :)

[alexey-medvedchikov]

@ndmckinley ok, I will write tests tomorrow.

[nat-henderson]

That's great! :)

[alexey-medvedchikov]

Added tests, running results:

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_withMasterAuthConfig$$'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_withMasterAuthConfig$ -timeout 120m
=== RUN   TestAccContainerCluster_withMasterAuthConfig
=== PAUSE TestAccContainerCluster_withMasterAuthConfig
=== CONT  TestAccContainerCluster_withMasterAuthConfig
--- PASS: TestAccContainerCluster_withMasterAuthConfig (1005.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	1005.796s

[nat-henderson]

Fantastic. I'll run them on my side then merge! :)

[nat-henderson]

Looks good!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!