Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for updating function code in place #1781

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

lukehoban
Copy link
Contributor

@lukehoban lukehoban commented Jul 16, 2018

Remove ForceNew from the source inputs on function resources, and add support for updating the function in place from a new source bucket+object.

This is similar to #1666, but includes test coverage and removes ForceNew from both source_archive_bucket and source_archive_object.

Tests:

$ /usr/local/bin/go test -v -timeout 1h github.com/terraform-providers/terraform-provider-google/google -run ^TestAccCloudFunctionsFunction
=== RUN   TestAccCloudFunctionsFunction_basic
=== RUN   TestAccCloudFunctionsFunction_update
=== RUN   TestAccCloudFunctionsFunction_pubsub
=== RUN   TestAccCloudFunctionsFunction_bucket
--- PASS: TestAccCloudFunctionsFunction_basic (34.82s)
--- PASS: TestAccCloudFunctionsFunction_pubsub (41.58s)
--- PASS: TestAccCloudFunctionsFunction_update (60.10s)
--- PASS: TestAccCloudFunctionsFunction_bucket (60.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-google/google 60.233s

Remove ForceNew from the source inputs on function resources, and add support for updating the function in place from a new source bucket+object.
@lukehoban
Copy link
Contributor Author

/cc @dustinblackman @paddycarver

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lukehoban!

@ghost
Copy link

ghost commented Nov 17, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants