Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quic_override to google_compute_target_https_proxy #1718

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Jun 28, 2018

Fixes #1365

/cc @danawillow

@danawillow danawillow changed the title Magic Modules changes. add quic_override to google_compute_target_https_proxy Jun 28, 2018
@danawillow
Copy link
Contributor

(don't mind the provider_compute_gen changes, that'll get figured out once I can merge the MM Autoscaler PR)

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the docs change requested in the MM PR, LGTM.

@danawillow danawillow merged commit 74c6403 into hashicorp:master Jun 29, 2018
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@ghost
Copy link

ghost commented Nov 17, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 17, 2018
@modular-magician modular-magician deleted the codegen-pr-316 branch November 16, 2024 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants