Implement 'licenses' field in compute_image resource #1717
Conversation
Signed-off-by: Matt Oswalt <[email protected]>
| @@ -29,6 +29,7 @@ func TestAccComputeImage_basic(t *testing.T) { | |||
| testAccCheckComputeImageFamily(&image, "family-test"), | |||
| testAccCheckComputeImageContainsLabel(&image, "my-label", "my-label-value"), | |||
| testAccCheckComputeImageContainsLabel(&image, "empty-label", ""), | |||
| testAccCheckComputeImageContainsLicense(&image, "https://www.googleapis.com/compute/v1/projects/vm-options/global/licenses/enable-vmx"), | |||
There was a problem hiding this comment.
I think I'd rather see this in its own test, just so we can verify that creating an image without a license also works.
There was a problem hiding this comment.
Yup you're right, this was lazy. Updated in d7c1bf9
| @@ -106,6 +106,13 @@ func resourceComputeImage() *schema.Resource { | |||
| Set: schema.HashString, | |||
| }, | |||
|
|
|||
| "licenses": &schema.Schema{ | |||
| Type: schema.TypeList, | |||
There was a problem hiding this comment.
Does order matter for licenses? Is it reasonable to expect someone to try and reference each individual license using interpolations?
There was a problem hiding this comment.
Ah, this is nice. So Google isn't expecting the order to be meaningful, but I'd say it might still be intuitive to keep this as a TypeList in case the user wants to be able to refer to it using interpolations. (I'm assuming they won't be able to do this if it's an unordered TypeSet). So not necessarily for compatibility reasons, but for UX reasons, might be useful to keep it as-is. Let me know if you disagree, I'm not married to it.
Signed-off-by: Matt Oswalt <[email protected]>
|
Thanks @paddycarver! |
|
Thank you! Apologies for the wait. I'm not sure how I feel about list vs set still, but we have a path forward if we decide we want to change it in the future, so let's ship it. :D |
Implement 'licenses' field in compute_image resource
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR implements the
licensesfield for GCP images in this provider (already exists in the Google API, just needed to be plumbed through).Terraform users can now use this provider to create images for nested virtualization, as well as other use cases for setting licenses on an image.
Closes #1045