Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis resource #1485

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

modular-magician
Copy link
Collaborator

@danawillow
Copy link
Contributor

Closing as this will be taken care of in a different PR

@danawillow danawillow closed this May 12, 2018
@danawillow danawillow reopened this May 17, 2018
@danawillow
Copy link
Contributor

changed my mind, reopening

@danawillow danawillow changed the title Magic Modules changes. Redis resource May 17, 2018
@@ -86,13 +86,6 @@ In addition to the arguments listed above, the following computed attributes are
Time of creation


## Timeouts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this section getting removed in this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was running into problems with null pointers or whatever they are in ruby when trying to generate everything, so I just fixed it here because it unblocked me. The liens resource has no timeouts, so they shouldn't be documented. I can do it separately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with leaving it as part of this, knowing the rationale of "the fix was needed to unblock this resource" :)

@danawillow danawillow merged commit 488b9e8 into hashicorp:master May 23, 2018
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants