-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis resource #1485
Redis resource #1485
Conversation
Closing as this will be taken care of in a different PR |
changed my mind, reopening |
feb78a2
to
6c51b7c
Compare
6c51b7c
to
891704a
Compare
@@ -86,13 +86,6 @@ In addition to the arguments listed above, the following computed attributes are | |||
Time of creation | |||
|
|||
|
|||
## Timeouts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this section getting removed in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I was running into problems with null pointers or whatever they are in ruby when trying to generate everything, so I just fixed it here because it unblocked me. The liens resource has no timeouts, so they shouldn't be documented. I can do it separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with leaving it as part of this, knowing the rationale of "the fix was needed to unblock this resource" :)
<!-- This change is generated by MagicModules. --> /cc @danawillow
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
/cc @danawillow