Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAM resources for Spanner databases. #1386

Merged
merged 4 commits into from
May 2, 2018

Conversation

paddycarver
Copy link
Contributor

Add new policy, binding, and member IAM resources for Spanner databases.
Fixes #1178.

Tests:

make testacc TEST=./google TESTARGS='-run=TestAccSpannerDatabaseIam'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccSpannerDatabaseIam -timeout 120m
=== RUN   TestAccSpannerDatabaseIamBinding
=== PAUSE TestAccSpannerDatabaseIamBinding
=== RUN   TestAccSpannerDatabaseIamMember
=== PAUSE TestAccSpannerDatabaseIamMember
=== RUN   TestAccSpannerDatabaseIamPolicy
=== PAUSE TestAccSpannerDatabaseIamPolicy
=== CONT  TestAccSpannerDatabaseIamBinding
=== CONT  TestAccSpannerDatabaseIamPolicy
=== CONT  TestAccSpannerDatabaseIamMember
--- PASS: TestAccSpannerDatabaseIamPolicy (27.04s)
--- PASS: TestAccSpannerDatabaseIamMember (34.96s)
--- PASS: TestAccSpannerDatabaseIamBinding (40.73s)
PASS
ok      github.com/terraform-providers/terraform-provider-google/google 40.741s

Add new policy, binding, and member IAM resources for Spanner databases.
Fixes #1178.
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddycarver
Copy link
Contributor Author

Just noticed I neglected to update the docs for this, I'll push a docs update momentarily.

@paddycarver
Copy link
Contributor Author

Added docs, does this still look good?

@paddycarver paddycarver merged commit 008316f into master May 2, 2018
@paultyng paultyng deleted the paddy_spanner_database_iam branch October 29, 2018 19:28
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
…ner_database_iam

Add IAM resources for Spanner databases.
@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants