Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ssl_policy to use v1 API #1368

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Update ssl_policy to use v1 API #1368

merged 2 commits into from
Apr 24, 2018

Conversation

nickjacques
Copy link
Contributor

  • Updates google.golang.org/api/compute/v1/compute-gen.go to latest version, required for:
  • Using v1 API for ssl_policy resources

These are pre-reqs for adding ssl_policy to Target HTTPS Proxies, as the target proxies currently use the v1 API. Mix-and-match with ssl_policy as a beta API would be... less than great.

@nickjacques
Copy link
Contributor Author

$ make testacc TEST=./google TESTARGS='-run=TestAccComputeSslPolicy_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeSslPolicy_* -timeout 120m
=== RUN   TestAccComputeSslPolicy_basic
=== RUN   TestAccComputeSslPolicy_profile
=== RUN   TestAccComputeSslPolicy_update
=== RUN   TestAccComputeSslPolicy_tls_version
=== RUN   TestAccComputeSslPolicy_custom
=== RUN   TestAccComputeSslPolicy_update_to_custom
=== RUN   TestAccComputeSslPolicy_update_from_custom
--- PASS: TestAccComputeSslPolicy_tls_version (29.24s)
--- PASS: TestAccComputeSslPolicy_basic (29.25s)
--- PASS: TestAccComputeSslPolicy_profile (29.25s)
--- PASS: TestAccComputeSslPolicy_custom (29.25s)
--- PASS: TestAccComputeSslPolicy_update_from_custom (45.24s)
--- PASS: TestAccComputeSslPolicy_update_to_custom (45.26s)
--- PASS: TestAccComputeSslPolicy_update (45.40s)
PASS
ok      github.com/terraform-providers/terraform-provider-google/google 45.440s

@rosbo rosbo self-assigned this Apr 24, 2018
@rosbo
Copy link
Contributor

rosbo commented Apr 24, 2018

Thanks @nickjacques. Merging

@rosbo rosbo merged commit 0d309b1 into hashicorp:master Apr 24, 2018
@nickjacques nickjacques deleted the ssl_policy_to_v1 branch April 24, 2018 22:06
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost unassigned rosbo Nov 18, 2018
@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants