Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disable_on_destroy flag to project_services #1293

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Add disable_on_destroy flag to project_services #1293

merged 1 commit into from
Apr 4, 2018

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Apr 4, 2018 •
edited by danawillow
Loading

Related: #1292

@rosbo rosbo requested a review from danawillow April 4, 2018 22:22
@rosbo
Copy link
Contributor Author

rosbo commented Apr 4, 2018

cc/ @morgante

danawillow
danawillow approved these changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I changed your PR description since it sounds like the issue in question was something else. I'm still good with this change though!

@rosbo rosbo merged commit 1bf076f into hashicorp:master Apr 4, 2018
@ghost
Copy link

ghost commented Nov 19, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosbo @danawillow