-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pod security policy #1192
Conversation
google/resource_container_cluster.go
Outdated
@@ -1063,6 +1090,32 @@ func resourceContainerClusterUpdate(d *schema.ResourceData, meta interface{}) er | |||
d.SetPartial("logging_service") | |||
} | |||
|
|||
// Disable update support for now: https://issuetracker.google.com/74063492 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the best way? I feel like maybe we might want to just use regular git / github for this, pull it out into its own branch, and leave the PR open with a note that it should be merged when the bug is closed. Commented-out-code makes me nervous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's a better idea. I'll do that now.
* move setid calls back * add support for pod security policy * pod security policy docs * Revert "move setid calls back" This reverts commit 0c7b2db. * cleanup * remove comments about disabling update
* move setid calls back * add support for pod security policy * pod security policy docs * Revert "move setid calls back" This reverts commit 0c7b2db. * cleanup * remove comments about disabling update
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes #1168