Add VPN gateway data source #1071
Conversation
| Required: true, | ||
| }, | ||
|
|
||
| "description": &schema.Schema{ |
There was a problem hiding this comment.
We order these fields "Required, Optional, Computed" - A field which is both Optional and Computed counts as Optional for this ordering.
|
|
||
| gateway, err := vpnGatewaysService.Get(project, region, name).Do() | ||
| if err != nil { | ||
| if gerr, ok := err.(*googleapi.Error); ok && gerr.Code == 404 { |
There was a problem hiding this comment.
I think you want handleNotFoundError.
There was a problem hiding this comment.
This actually includes the 404 check - it returns the not-found error if the resource doesn't exist, and a regular error otherwise. Just if err != nil { return handleNotFoundError(...) }
There was a problem hiding this comment.
I've just pushed another change. Does that work?
Also, I had modeled the original error handling code on existing examples such as data_source_compute_network, data_source_compute_subnetwork or data_source_compute_global_address. There might be other such examples. Are those incorrect as well?
|
Thanks @ndmckinley, I've pushed the requested updates. |
|
|
||
| gateway, err := vpnGatewaysService.Get(project, region, name).Do() | ||
| if err != nil { | ||
| if gerr, ok := err.(*googleapi.Error); ok && gerr.Code == 404 { |
There was a problem hiding this comment.
This actually includes the 404 check - it returns the not-found error if the resource doesn't exist, and a regular error otherwise. Just if err != nil { return handleNotFoundError(...) }
| } | ||
|
|
||
| return fmt.Errorf("Error reading VPN Gateway: %s", err) | ||
| // The resource doesn't exist anymore |
There was a problem hiding this comment.
Comment out of date now - sorry for the nitpicks!
|
Thanks for working with me on that! Running the tests now, and will merge when they're done. |
|
No worries! By the way, did you see my comment regarding the code for the network, subnetwork and global-address data sources? I had modeled my original error handling code based on those. Are they incorrect? |
|
Thanks for calling that out! You're right, those did not move to the new-model 404 handler - we should fix it. :) |
|
Ok I see, I'm happy to submit a separate PR for that. I'll ping you when it's done. |
|
Oh wow, that's great! Thanks! :) |
Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
No description provided.