Support multiple users with the same name for different host for 1st gen. #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
changed the title
--- PASS: TestAccGoogleSqlUser_firstGen (86.56s)
--- PASS: TestAccGoogleSqlUser_secondGen (508.87s) |
danawillow
approved these changes
Feb 9, 2018
google/resource_sql_user_test.go
Outdated
| resource "google_sql_user" "user" { | ||
| name = "user%s" | ||
| resource "google_sql_user" "user1" { | ||
| name = "john" |
There was a problem hiding this comment.
I'm sorry to be That Person but can we use a gender-neutral name here?
There was a problem hiding this comment.
Sure. Changed for admin.
| database_version = "POSTGRES_9_6" | ||
| database_version = "MYSQL_5_6" | ||
| # First-generation instance regions are not the conventional | ||
| # Google Compute Engine region. See argument reference below. |
| region = "us-central1" | ||
|
|
||
| settings { | ||
| # Second-generation instance tier are based on the machine |
| @@ -52,6 +49,10 @@ The following arguments are supported: | |||
|
|
|||
| - - - | |||
|
|
|||
| * `host` - (Optional) The host the user can connect from. This is only supported | |||
| for first generation SQL instance. Don't set this field for second generation | |||
| @@ -52,6 +49,10 @@ The following arguments are supported: | |||
|
|
|||
| - - - | |||
|
|
|||
| * `host` - (Optional) The host the user can connect from. This is only supported | |||
| for first generation SQL instance. Don't set this field for second generation | |||
| SQL instance. Can be an IP address. Changing this forces a new resource to be created. | |||
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
…gen. (hashicorp#1066) * Support multiple users with the same name for different host for 1st gen. * Fix typo and rename user
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1057
D0for aPOSTGRES_9_6instance is not a valid tier.