Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark subnetwork field in container cluster as computed #1061

Merged
merged 2 commits into from
Feb 8, 2018

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Feb 8, 2018

Fixes failing tests: TestAccContainerCluster_withNodeConfig and TestAccContainerCluster_withNodeConfigScopeAlias

If the subnetwork was not specified in the config, it would create a perpetual diff.

subnetwork: "default" => "" (forces new resource)

@rosbo rosbo requested a review from danawillow February 8, 2018 17:52
@rosbo rosbo merged commit e8c5266 into hashicorp:master Feb 8, 2018
@rosbo rosbo deleted the cluster-compute-subnetwork branch February 8, 2018 18:04
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants