-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL DB Instance has attribute first_ip_address #1050
Conversation
Signed-off-by: Desmond Pompa Alarcon Rawls <[email protected]>
Signed-off-by: Genevieve LEsperance <[email protected]>
Signed-off-by: Desmond Pompa Alarcon Rawls <[email protected]>
Signed-off-by: Genevieve LEsperance <[email protected]>
Hey @danawillow. I opened this PR after discussions in #912 and hashicorp/terraform#17048. Is there anything about this attribute or it's implementation that we can fix? This is currently a blocker for us as there is no way to have this particular resource have a count. |
I see in the other issue that a workaround of using |
Since the terraform doesn't apply without that environment variable, it means resources that all our teams use in CI/CD pipelines would have to support that, as well as asking it of all the users that go directly to use these terraform templates. It wasn't really something we wanted to recommend since it risks actually swallowing relevant errors. When we choose one output syntax over the other either the database-turned-off case works and the database-turned-on fails during Ideally we could have a terraform module for creating this database, but due to the inability to actually make it work with the terraform syntax and the resource's structure, it has to be mandatory. Currently, teams that weren't opting in to this database are seeing a recurring issue opened here (#1138) and they can't avoid it by opting out of the database since we had to make it a mandatory resource. |
Thanks @genevieve! That sounds reasonable, and the code looks good. Merging now. |
Oh wait, I got ahead of myself. I'm going to keep it in, but would you mind sending a follow-up PR for changes to the docs to add this attribute? Please tag me in it and I'll review it right away. |
Signed-off-by: Modular Magician <[email protected]>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Related Issues:
#912
hashicorp/terraform#17048