Diff suppress unconventional public image family naming pattern #1024
Conversation
rosbo
force-pushed
the
diff-suppress-unconventionel-public-image-family-name
branch
from
b8f5498 to
e84188d
Compare
google/resource_compute_disk.go
Outdated
| @@ -495,3 +496,91 @@ func diskImageProjectNameEquals(project1, project2 string) bool { | |||
|
|
|||
| return project1 == project2 | |||
| } | |||
|
|
|||
| func diskImageEquals(oldImageName, newImageName string) bool { | |||
| return strings.Contains(oldImageName, newImageName) | |||
There was a problem hiding this comment.
What's the case where it's the image name that's a substring of the other one (as opposed to the family name that's a substring of the image name)?
There was a problem hiding this comment.
Like, could this be oldImageName == newImageName?
There was a problem hiding this comment.
Ah I see :) Yes! Now that I added a specific one for for testing equality for family.
Done. I kept the diskImageEquals method even if it is trivial. I find that it reads better in diskImageDiffSuppress.
rosbo
deleted the
diff-suppress-unconventionel-public-image-family-name
branch
…icorp#1024) * DiffSuppress for all public images family names * Update documentation * TF_ACC guard * diskImageEquals should use ==
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Help for #988.
There is an acceptance test that will catch new image patterns and fail if we don't support them.
I would highly encourage people to use the
google_compute_imagedata source or an image self_link.I wish we could make a network call in DiffSuppressFunc...
I am starting to wonder if we should just stop reading the image field for the api for disk and instance (import won't work properly and we won't detect image changes outside Terraform). Reading from the image from the API was added in #948.