Support cloud sql private ip (incorporating previous PR feedback) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
For context, a link to the previous PR: #46 |
danawillow
reviewed
Nov 20, 2018
| reserved_peering_ranges = ["${google_compute_global_address.foobar.name}"] | ||
| } | ||
|
|
||
| # TODO figure out a way to specify the dependency to the connection resource |
There was a problem hiding this comment.
do you still need this TODO?
| @@ -714,6 +738,42 @@ resource "google_sql_database_instance" "instance-failover" { | |||
| `, instanceName, failoverName) | |||
| } | |||
|
|
|||
| func testAccSqlDatabaseInstance_with_private_network(databaseName, networkName, addressRangeName string) string { | |||
| return fmt.Sprintf(` | |||
| resource "google_compute_network" "foobar" { | |||
There was a problem hiding this comment.
FYI I think the test will run faster if you do auto_create_subnetworks = false (unless you need them for the test, in which case carry on)
| @@ -594,6 +594,30 @@ func TestAccSqlDatabaseInstance_basic_with_user_labels(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccSqlDatabaseInstance_with_private_network(t *testing.T) { | |||
There was a problem hiding this comment.
nit: could it be called TestAccSqlDatabaseInstance_withPrivateNetwork?
|
Thanks for taking a look :) |
danawillow
approved these changes
Nov 20, 2018
danawillow
suggested changes
Nov 20, 2018
|
Documentation added. |
modular-magician
pushed a commit
to modular-magician/terraform-provider-google-beta
that referenced
this pull request
Nov 21, 2018
|
Closing this out. Thanks again for the help. |
danawillow
approved these changes
Nov 21, 2018
nat-henderson
pushed a commit
that referenced
this pull request
Dec 11, 2018
Support cloud sql private ip (incorporating previous PR feedback)
nat-henderson
pushed a commit
that referenced
this pull request
Dec 12, 2018
Support cloud sql private ip (incorporating previous PR feedback)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up on the work done by @yhuang incorporating the feedback given by @danawillow.