Nat rule #22
Nat rule #22
Conversation
|
Will review once #21 is meged |
| return &schema.Resource{ | ||
| Create: resourceArmLoadBalancerNatRuleCreate, | ||
| Read: resourceArmLoadBalancerNatRuleRead, | ||
| Update: resourceArmLoadBalancerNatRuleCreate, |
There was a problem hiding this comment.
Would we rename this to resourceArmLoadBalancerNatRuleCreateUpdate as it is doing both?
| existingNatRule, existingNatRuleIndex, exists := findLoadBalancerNatRuleByName(loadBalancer, d.Get("name").(string)) | ||
| if exists { | ||
| if d.Get("name").(string) == *existingNatRule.Name { | ||
| // this probe is being updated/reapplied remove old copy from the slice |
There was a problem hiding this comment.
I believe this should be nat rule not probe
|
|
||
| if v, ok := d.GetOk("enable_floating_ip"); ok { | ||
| enableFloatingIP := v.(bool) | ||
| properties.EnableFloatingIP = utils.Bool(enableFloatingIP) |
There was a problem hiding this comment.
These can be combined into: properties.EnableFloatingIP = utils.Bool(v.(bool))
`
| ID: rule.ID, | ||
| } | ||
|
|
||
| properties.FrontendIPConfiguration = &feip |
There was a problem hiding this comment.
This could become:
properties.FrontendIPConfiguration = &network.SubResource{
ID: rule.ID,
}| page_title: "Azure Resource Manager: azurestack_lb_nat_rule" | ||
| sidebar_current: "docs-azurestack-resource-loadbalancer-nat-rule" | ||
| description: |- | ||
| Create a LoadBalancer NAT Rule. |
|
|
||
| # azurestack_lb_nat_rule | ||
|
|
||
| Create a LoadBalancer NAT Rule. |
| Required: true, | ||
| StateFunc: ignoreCaseStateFunc, | ||
| DiffSuppressFunc: ignoreCaseDiffSuppressFunc, | ||
| }, |
There was a problem hiding this comment.
Could we get some validation here?
…r-azurestack into nat_rule
| StateFunc: ignoreCaseStateFunc, | ||
| DiffSuppressFunc: ignoreCaseDiffSuppressFunc, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| "Tcp", |
There was a problem hiding this comment.
Could we use the values provider by the SDK string(network.TransportProtocolTCP),
| "frontend_port": { | ||
| Type: schema.TypeInt, | ||
| Required: true, | ||
| }, |
There was a problem hiding this comment.
Could we validate the value is a valid port here?
| "backend_port": { | ||
| Type: schema.TypeInt, | ||
| Required: true, | ||
| }, |
There was a problem hiding this comment.
Could we validate the value is a valid port here?
|
tests pass: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Made a mistake changing the names of the tests on #21, so this will depend on that PR