Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client config data source #9

Merged

Conversation

thetonymaster
Copy link
Contributor

Add support for AzureStack Client config datasource

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @thetonymaster

Thanks for this PR - if we can remove the Azure Public specifics then this should be good to go 👍


# Data Source: azurestack_client_config

Use this data source to access the configuration of the Azure Resource Manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure Resource Manager -> Azure Stack

"github.com/hashicorp/terraform/terraform"
)

func TestAccDataSourceAzureRMClientConfig_basic(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AzureRM -> AzureStack


// Wraps resource.TestCheckResourceAttr to prevent leaking values to console
// in case of mismatch
func testAzureRMClientConfigAttr(name, key, value string) resource.TestCheckFunc {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AzureRM -> AzureStack

}
}

func testAzureRMClientConfigGUIDAttr(name, key string) resource.TestCheckFunc {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AzureRM -> AzureStack


---

~> **Note:** the following fields are only available when authenticating via a Service Principal (as opposed to using the Azure CLI):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't support the Azure CLI for Azure Stack - as such this note can be removed?

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Test passes:

screenshot 2018-07-17 at 06 00 44

@tombuildsstuff tombuildsstuff merged commit 480fdb6 into hashicorp:master Jul 17, 2018
tombuildsstuff added a commit that referenced this pull request Jul 17, 2018
@katbyte katbyte added this to the 0.2.0 milestone Aug 13, 2018
@ghost
Copy link

ghost commented Jun 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants