-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client config data source #9
Client config data source #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @thetonymaster
Thanks for this PR - if we can remove the Azure Public specifics then this should be good to go 👍
website/docs/d/client_config.html.md
Outdated
|
||
# Data Source: azurestack_client_config | ||
|
||
Use this data source to access the configuration of the Azure Resource Manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure Resource Manager
-> Azure Stack
"github.com/hashicorp/terraform/terraform" | ||
) | ||
|
||
func TestAccDataSourceAzureRMClientConfig_basic(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AzureRM
-> AzureStack
|
||
// Wraps resource.TestCheckResourceAttr to prevent leaking values to console | ||
// in case of mismatch | ||
func testAzureRMClientConfigAttr(name, key, value string) resource.TestCheckFunc { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AzureRM
-> AzureStack
} | ||
} | ||
|
||
func testAzureRMClientConfigGUIDAttr(name, key string) resource.TestCheckFunc { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AzureRM
-> AzureStack
website/docs/d/client_config.html.md
Outdated
|
||
--- | ||
|
||
~> **Note:** the following fields are only available when authenticating via a Service Principal (as opposed to using the Azure CLI): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't support the Azure CLI for Azure Stack - as such this note can be removed?
- Removing Public API references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Add support for AzureStack Client config datasource