Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds managed disk support to Virtual Machines #85

Merged
merged 14 commits into from
Jun 19, 2019
Merged

Adds managed disk support to Virtual Machines #85

merged 14 commits into from
Jun 19, 2019

Conversation

petems
Copy link
Contributor

@petems petems commented May 15, 2019 •
edited by katbyte
Loading

  • updated virtual machine documentation

Rebase of #77

Blocked waiting for #84

fixes #44

@petems petems changed the title Adds managed disk support Adds managed disk support [WIP] May 15, 2019
@petems petems force-pushed the managed_disks_profile branch from c397855 to 54d5c12 Compare May 15, 2019 16:24
@ghost ghost added size/XXL and removed size/XL labels May 15, 2019
@petems petems force-pushed the managed_disks_profile branch from 54d5c12 to 3af29db Compare June 7, 2019 15:47
@ghost ghost added size/XL and removed size/XXL labels Jun 7, 2019
@katbyte katbyte force-pushed the managed_disks_profile branch from 3af29db to 9415c5a Compare June 7, 2019 16:39
@ghost ghost added size/XXL dependencies and removed size/XL labels Jun 7, 2019
@katbyte katbyte mentioned this pull request Jun 8, 2019
Closed
@katbyte katbyte changed the title Adds managed disk support [WIP] Adds managed disk support to Virtual Machines Jun 8, 2019
@katbyte katbyte requested a review from tombuildsstuff June 8, 2019 20:43
@katbyte
Copy link
Collaborator

katbyte commented Jun 8, 2019

Added managed disk & platform image resources. Ready for a review

@katbyte katbyte added this to the v0.8.0 milestone Jun 8, 2019
@katbyte
Copy link
Collaborator

katbyte commented Jun 9, 2019

Thanks for spotting those errors @jbpaux, pushing fixes now.

tombuildsstuff
tombuildsstuff approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring some minor casing questions; this otherwise LGTM 👍

azurestack/data_source_platform_image_test.go Outdated Show resolved Hide resolved
azurestack/resource_arm_managed_disk.go Outdated Show resolved Hide resolved
azurestack/resource_arm_managed_disk.go Outdated Show resolved Hide resolved
azurestack/resource_arm_managed_disk.go Outdated Show resolved Hide resolved
azurestack/resource_arm_managed_disk.go Outdated Show resolved Hide resolved
azurestack/resource_arm_virtual_machine_scale_set.go Show resolved Hide resolved
katbyte added a commit that referenced this pull request Jun 19, 2019
@katbyte
Update CHANGELOG.md to include #85
b5e0588
@katbyte katbyte merged commit 4d6eeac into hashicorp:master Jun 19, 2019
@petems petems deleted the managed_disks_profile branch June 21, 2019 14:44
@ghost
Copy link

ghost commented Jul 19, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

1 similar comment
@ghost
Copy link

ghost commented Jul 19, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cblackuk cblackuk cblackuk left review comments

@jbpaux jbpaux jbpaux left review comments

@katbyte katbyte katbyte left review comments

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/XXL
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Managed disk functionality is commented out but still in schema
5 participants
@petems @katbyte @tombuildsstuff @jbpaux @cblackuk