Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual network gateway connection #35

Merged

Conversation

thetonymaster
Copy link
Contributor

Depends on #31

@ghost ghost added the size/XXL label Aug 31, 2018
@katbyte katbyte added this to the 0.4.0 milestone Sep 6, 2018
@katbyte
Copy link
Collaborator

katbyte commented Sep 7, 2018

Will review after #31 has been merged

@ghost ghost added the size/XXL label Sep 7, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thetonymaster,

Thank you for the PR. Other then a few comments i have left inline this is looking good.

Type: schema.TypeString,
Optional: true,
ForceNew: true,
ValidateFunc: azure.ValidateResourceId,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional values can be empty to allow interpolation:

ValidateFunc: azure.ValidateResourceIDOrEmpty

Type: schema.TypeString,
Optional: true,
ForceNew: true,
ValidateFunc: azure.ValidateResourceId,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also should be ValidateFunc: azure.ValidateResourceIDOrEmpty

"local_network_gateway_id": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: azure.ValidateResourceId,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also should be ValidateFunc: azure.ValidateResourceIDOrEmpty

}

err = future.WaitForCompletionRef(ctx, client.Client)
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {

}

err = future.WaitForCompletionRef(ctx, client.Client)
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {


```hcl
resource "azurestack_resource_group" "test" {
name = "test"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get these assignments aligned here?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thetonymaster,

Thank you for the changes, aside from one left inline comment this LGTM now. Once that one comment has been address I can get this merged.


```hcl
resource "azurestack_resource_group" "us" {
name = "us"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we align the assignments in this example terraform?

@katbyte
Copy link
Collaborator

katbyte commented Sep 10, 2018

Tests pass:
screen shot 2018-09-10 at 12 37 24

@ghost ghost added the size/XXL label Sep 10, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick push @thetonymaster! LGTM 💯

@katbyte katbyte merged commit c9b3138 into hashicorp:master Sep 10, 2018
katbyte added a commit that referenced this pull request Sep 10, 2018
@ghost
Copy link

ghost commented Jun 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants