-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azurestack Route #27
Azurestack Route #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thetonymaster,
For the most part this LGTM outside of some stylistic comments i have left inline. As i am going on vacation today i am just going to make the edits myself to get this merged, hope you don't mind 🙂
azurestack/resource_arm_route.go
Outdated
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get a ValidateFunc: validation.NoZeroValues,
here?
azurestack/resource_arm_route.go
Outdated
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and another ValidateFunc: validation.NoZeroValues,
here?
azurestack/resource_arm_route.go
Outdated
azureStackLockByName(rtName, routeTableResourceName) | ||
defer azureStackUnlockByName(rtName, routeTableResourceName) | ||
|
||
properties := network.RoutePropertiesFormat{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could all become
route := network.Route{
Name: &name,
RoutePropertiesFormat: &network.RoutePropertiesFormat{
AddressPrefix: &addressPrefix,
NextHopType: network.RouteNextHopType(nextHopType),
},
}
if v, ok := d.GetOk("next_hop_in_ip_address"); ok {
route.RoutePropertiesFormat.NextHopIPAddress = utils.String(v.(string))
}
azurestack/resource_arm_route.go
Outdated
} | ||
|
||
err = future.WaitForCompletionRef(ctx, client.Client) | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {
azurestack/resource_arm_route.go
Outdated
} | ||
|
||
err = future.WaitForCompletionRef(ctx, client.Client) | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also could be: if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {
return fmt.Sprintf(` | ||
resource "azurestack_resource_group" "test" { | ||
name = "acctestRG-%d" | ||
location = "%s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we align these test tf assignments?
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
depends on #26