Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azurestack Route #27

Merged
merged 5 commits into from
Aug 22, 2018
Merged

Azurestack Route #27

merged 5 commits into from
Aug 22, 2018

Conversation

thetonymaster
Copy link
Contributor

depends on #26

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thetonymaster,

For the most part this LGTM outside of some stylistic comments i have left inline. As i am going on vacation today i am just going to make the edits myself to get this merged, hope you don't mind 🙂

Type: schema.TypeString,
Required: true,
ForceNew: true,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a ValidateFunc: validation.NoZeroValues, here?

Type: schema.TypeString,
Required: true,
ForceNew: true,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and another ValidateFunc: validation.NoZeroValues, here?

azureStackLockByName(rtName, routeTableResourceName)
defer azureStackUnlockByName(rtName, routeTableResourceName)

properties := network.RoutePropertiesFormat{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could all become

route := network.Route{
		Name: &name,
		RoutePropertiesFormat: &network.RoutePropertiesFormat{
			AddressPrefix: &addressPrefix,
			NextHopType:   network.RouteNextHopType(nextHopType),
		},
	}

	if v, ok := d.GetOk("next_hop_in_ip_address"); ok {
		route.RoutePropertiesFormat.NextHopIPAddress = utils.String(v.(string))
	}

}

err = future.WaitForCompletionRef(ctx, client.Client)
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {

}

err = future.WaitForCompletionRef(ctx, client.Client)
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also could be: if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {

return fmt.Sprintf(`
resource "azurestack_resource_group" "test" {
name = "acctestRG-%d"
location = "%s"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we align these test tf assignments?

@katbyte katbyte added this to the 0.4.0 milestone Aug 22, 2018
@katbyte katbyte merged commit ce8d3da into hashicorp:master Aug 22, 2018
katbyte added a commit that referenced this pull request Aug 22, 2018
@ghost
Copy link

ghost commented Jun 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants