Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load balancer rule #25

Merged
merged 12 commits into from
Aug 13, 2018
Merged

Load balancer rule #25

merged 12 commits into from
Aug 13, 2018

Conversation

thetonymaster
Copy link
Contributor

No description provided.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thetonymaster,

Aside from a few minor comments i have left inline this mostly LGTM.

"frontend_ip_configuration_name": {
Type: schema.TypeString,
Required: true,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a NoZeroValues here?

Type: schema.TypeInt,
Optional: true,
Computed: true,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get some validation here: validation.IntBetween(4,30)

d.Set("frontend_port", config.LoadBalancingRulePropertiesFormat.FrontendPort)
d.Set("backend_port", config.LoadBalancingRulePropertiesFormat.BackendPort)

if config.LoadBalancingRulePropertiesFormat.EnableFloatingIP != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we break this out into a block? ie:

    if properties := config.LoadBalancingRulePropertiesFormat; properties != nil {
		d.Set("protocol", properties.Protocol)
		...
    }

LoadBalancingRulePropertiesFormat: &properties,
}

return &lbRule, nil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we change this to:

    return &network.LoadBalancingRule{
		Name: utils.String(d.Get("name").(string)),
		LoadBalancingRulePropertiesFormat: &properties,
	}, nil

ID: &v,
}

properties.Probe = &pid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this to:

        properties.Probe = &network.SubResource{
			ID: &v,
		}

ID: &v,
}

properties.BackendAddressPool = &beAP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here:

        properties.FrontendIPConfiguration = &network.SubResource{
			ID: rule.ID,
		}

@katbyte katbyte added this to the 0.3.0 milestone Aug 13, 2018
@katbyte
Copy link
Collaborator

katbyte commented Aug 13, 2018

Thank you for these updates @thetonymaster, LGTM now 👍

@katbyte
Copy link
Collaborator

katbyte commented Aug 13, 2018

Tests pass:
screen shot 2018-08-13 at 13 12 12

@katbyte katbyte merged commit 76b9eee into hashicorp:master Aug 13, 2018
katbyte added a commit that referenced this pull request Aug 13, 2018
@ghost
Copy link

ghost commented Jun 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants