CosmosDB: Added EnableAggregationPipeline to Cosmos DB capabilities

[jamesggraf]

I've never written anything in Go and I'm not 100% certain on how to test this so please be gentle :)

Fixes #1848

[tombuildsstuff]

hey @jamesggraf

Thanks for this PR :)

I've taken a look through and this mostly LGTM - if we can add this new Capability to the documentation (and the tests pass) we should be able to get this merged :)

Thanks!

[tombuildsstuff]

hey @jamesggraf

Thanks for adding the property to the documentation - this now LGTM, I'll kick off the test suite now 👍

Thanks!

[tombuildsstuff]

hey @jamesggraf

So I've run the test suite for this and it appears this fails because the feature isn't available:

------- Stdout: -------
=== RUN   TestAccAzureRMCosmosDBAccount_aggregation
--- FAIL: TestAccAzureRMCosmosDBAccount_aggregation (1092.50s)
	testing.go:513: Step 0 error: After applying this step, the plan was not empty:
		
		DIFF:
		
		UPDATE: azurerm_cosmosdb_account.test
		  capabilities.#:               "0" => "1"
		  capabilities.2476034231.name: "" => "EnableAggregationPipeline"

Out of interest - do you know if this feature is in an invite-only Beta/Preview?

Thanks!

[jamesggraf]

Not as far as I know? If I enable that feature through the Preview Features pane in the Cosmos UI I see that capability listed as being enabled. Can you confirm that you see the same thing when you set it? Is this flag just not available through their API?

[jamesggraf]

Can you confirm that that test is using a MongoDB database under Cosmos?

[katbyte]

Hi @jamesggraf,

I can confirm the test is using mongo, you can see it here

[jamesggraf]

Thanks katbyte, is there documentation for how these tests are run? I'd like to better understand why Terraform is having trouble enabling this capability even though I've seen it try to unset it after it's enabled manually through Azure's portal.

[katbyte]

@jamesggraf,

The tests are usually run against our test subscription. The runner:

• does an apply and stands up all the required resources
• reads back in the state (as normal)
• does a plan and checks to make sure it is empty
• does any desired checks on the state
• and then in this case does an import/read and verifies the imported state matches the current state

The step that is failing here is after applying the test config the plan is still not empty.

[tombuildsstuff]

hey @jamesggraf

Thanks for this PR - unfortunately at this time this PR is blocked on an upstream issue in the Azure API (which is being tracked here - as such I've currently assigned this PR to the "Blocked" milestone.

Rather than leaving this PR stagnant, I hope you don't mind but I'm going to close this issue temporarily whilst we wait for the issue in the API to be fixed; once the issue in the API is fixed we'll re-open this PR and run the tests/get this merged - however at this time we're unable to proceed with this until the bug in the API is fixed, so I hope you don't mind me temporarily closing this.

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!