CDN endpoint: Test for Premium_Verizon, optional values fix #9902
Conversation
…TypesToCompress, GeoFilters
There was a problem hiding this comment.
Thanks for the PR @AliAllomani - Aside from two questions i have left inline this looks good! Once those are addressed this should be good to merge
| contentTypes := flattenAzureRMCdnEndpointContentTypes(props.ContentTypesToCompress) | ||
| if err := d.Set("content_types_to_compress", contentTypes); err != nil { | ||
| return fmt.Errorf("Error setting `content_types_to_compress`: %+v", err) | ||
| if _, ok := d.GetOk("content_types_to_compress"); ok { |
There was a problem hiding this comment.
I don't think we need this check? or does the API return a default value?
| geoFilters := flattenCdnEndpointGeoFilters(props.GeoFilters) | ||
| if err := d.Set("geo_filter", geoFilters); err != nil { | ||
| return fmt.Errorf("Error setting `geo_filter`: %+v", err) | ||
| if _, ok := d.GetOk("geo_filter"); ok { |
There was a problem hiding this comment.
I don't think we need this check? or does the API return a default value?
|
Additionally these tests are failing: |
|
@katbyte Thank you for your review Updated and passed acceptance tests |
|
This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.42.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
EndpointProperties.ContentTypesToCompress,EndpointProperties.GeoFiltersonly when values are set forcontent_types_to_compress,geo_filter.EndpointProperties.DeliveryPolicyonly when SKU set toMicrosoft_Standard.Fixes #9895