-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource/Data Source: azurerm_ssh_public_key #9842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @AliAllomani - overall this looks good, but i have two questions:
- is this only for VMs? if so would it make sense to call it
azurerm_virtual_machine_ssh_public_key
? - should be be normalizing the ssh key at all?
thanks
Co-authored-by: kt <[email protected]>
Hello @katbyte, This can be considered as ssh keys store which can be used with any resource that accepts ssh key as input, no only virtual machines, as there are several azure services need ssh keys. The service also support generating ssh keys but due to security considerations and that the api returns the private key only one time on generation i think it wouldn't be possible to add this feature to the terraform resource, if we compare it with aws it would be corresponding to Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AliAllomani - this LGTM 👍
This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.42.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Added new resource and data source
azurerm_ssh_public_key
to support creation/retrieving SSH Public KeysFixes #9822
Documentation Updated + Acceptance test added and passed.