frontdoor: updating to use a generated Resource ID Formatter/Parser/Validator #9750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables this to be threaded through directly from the FrontDoor ID
…match the upcoming generated name
…e for the strict method
…Frontend Endpoint
…rs for HealthProbe
…Web Application Firewall Policy
|
Tests pass:
|
jackofallops
approved these changes
Dec 8, 2020
WodansSon
approved these changes
Dec 8, 2020
WodansSon
added a commit
that referenced
this pull request
Dec 8, 2020
tombuildsstuff
added a commit
that referenced
this pull request
Dec 9, 2020
|
This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.40.0"
}
# ... other configuration ... |
|
Does it fix #8039 too? |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around a series of bugs in the FrontDoor API - by parsing these Resource ID's case insensitively and then rewriting them within Terraform, ensuring that these are consistent from Terraform's point of view.
Whilst this works when the
keyof the key-value pair is returned in the incorrect case, unfortunately we can't workaround the value being incorrect - ultimately the FrontDoor Team needs to fix the API to comply with the ARM/HTTP Spec.. but this is the best we can do at this point in time 🤷Fixes #8208