bot: switching the hand-written ID Parsers out for generated ones #9690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
force-pushed
the
r/resource-ids/bot
branch
from
cb1b663 to
4bbf78b
Compare
tombuildsstuff
force-pushed
the
r/resource-ids/bot
branch
from
4bbf78b to
edd6b43
Compare
|
Acctests look good 👍 |
tombuildsstuff
added a commit
that referenced
this pull request
Dec 7, 2020
|
This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches all of the Bot Resources over to using Generated Resource ID Parsers - ultimately this contains the following:
Improvements:
azurerm_bot_channel_directline- support for enhanced import validationazurerm_bot_channel_email- support for enhanced import validationazurerm_bot_channel_ms_teams- support for enhanced import validationazurerm_bot_channel_slack- support for enhanced import validationazurerm_bot_channels_registration- support for enhanced import validationazurerm_bot_connection- support for enhanced import validationazurerm_bot_web_app- support for enhanced import validationBug Fixes:
azurerm_bot_channel_directline- the fieldbot_nameis now ForceNew to match the documentation/API behaviourazurerm_bot_channel_ms_teams- the fieldbot_nameis now ForceNew to match the documentation/API behaviourazurerm_bot_channel_slack- the fieldbot_nameis now ForceNew to match the documentation/API behaviourazurerm_bot_connection- the fieldbot_nameis now ForceNew to match the documentation/API behaviour