Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_solution - add support of tags #9048

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Oct 28, 2020

Fixes #8751

💤 make testacc TEST=./azurerm/internal/services/loganalytics/tests TESTARGS='-run TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/loganalytics/tests -v -run TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
=== PAUSE TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
=== CONT  TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
--- PASS: TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring (177.51s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/loganalytics/tests  177.550s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.34.0 milestone Oct 28, 2020
@katbyte katbyte merged commit 22babdc into hashicorp:master Oct 29, 2020
katbyte added a commit that referenced this pull request Oct 29, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for tags in resource azurerm_log_analytics_solution
3 participants