New resource: azurerm_virtual_hub_ip_configuration
#8912
Conversation
WodansSon
changed the title
azurerm_virtual_hub_ip_configuration
There was a problem hiding this comment.
Thanks for the PR @neil-yechenwei - i've got some questions around the name of this resource and what it does. once they are addressed i'll give this a more through review
|
|
||
| # azurerm_virtual_hub_ip_configuration | ||
|
|
||
| Manages a Virtual Hub IP Configuration. |
There was a problem hiding this comment.
I'm not sure what a Virtual Hub IP Configuration is. Is this an IP in the virtual hub, is this configuring something specific?
There was a problem hiding this comment.
Yes. I assume it's an IP in the virtual hub.
| Manages a Virtual Hub IP Configuration. | ||
| --- | ||
|
|
||
| # azurerm_virtual_hub_ip_configuration |
There was a problem hiding this comment.
would this make more sense as
| # azurerm_virtual_hub_ip_configuration | |
| # azurerm_virtual_hub_ip |
|
|
||
| * `name` - (Required) The name which should be used for this Virtual Hub IP Configuration. Changing this forces a new resource to be created. | ||
|
|
||
| * `resource_group_name` - (Required) The name of the Resource Group where the Virtual Hub IP Configuration should exist. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
can this be different then the RG of the virtual hub? the id seemsto be based off the hub indicating we can grab this from the virtual hub id
|
@katbyte , thanks for your comments. I've updated code. Please have a look. Thanks. |
There was a problem hiding this comment.
Thanks @neil-yechenwei, couple more comments and a failing test to fix and this should be good to merge:
TestAccAzureRMVirtualHubIP_requiresImport: testing.go:684: Step 0 error: Check failed: Check 1/1 error: ID was missing the `ipConfigurations` element
azurerm/internal/services/network/tests/virtual_hub_ip_resource_test.go
Outdated
Show resolved
Hide resolved
|
@katbyte , thanks for your comments. I've updated code. Please have a look. Thanks. |
There was a problem hiding this comment.
Thanks @neil-yechenwei - aside from one comment this LGTM 👍
|
This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.35.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
API Spec: https://docs.microsoft.com/en-us/rest/api/virtualwan/virtualhubipconfiguration/createorupdate
--- PASS: TestAccAzureRMVirtualHubIPConfiguration_basic (1383.60s)
--- PASS: TestAccAzureRMVirtualHubIPConfiguration_requiresImport (1383.61s)
--- PASS: TestAccAzureRMVirtualHubIPConfiguration_complete (1470.50s)
--- PASS: TestAccAzureRMVirtualHubIPConfiguration_update (1505.16s)