Add timezone logic app recurrence

[Lucretius]

Resolves the other part of #4316

According to this documentation time_zone is only applicable during start_time.

The list of time zones is not provided exactly. This documentation seems to indicate its the list I posted in the code - though its also unclear whether or not punctuation needs to be removed.

Fixes #4316

[tombuildsstuff]

hey @Lucretius

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can update the test to confirm that it's possible to update the timezone here then this otherwise LGTM 👍

Thanks!

[Lucretius]

Alright, UTC has been set as the default for time_zone, and an old test which just sets the start_time has been updated to verify. I also updated the other test to ensure update behavior works.

[katbyte]

Hey @Lucretius,

Overall this looks good, but there is some failing tests:

TestAccAzureRMLogicAppTriggerRecurrence_hour: testing.go:684: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=9) "time_zone": (string) (len=3) "UTC"
        }

looks like you'll need to change it from default to computed?

[Lucretius]

Swapping the property to computed seemed to fix the test locally. I also noticed that the timezones did not seem to like punctuation (the docs seemed to hint at this) so the timezone list now does not contain any punctuation (U.S. East -> US East). All tests were run locally and passed.

[jackofallops]

Tests passing:

[jackofallops]

Thanks @Lucretius - LGMT now the tests are fixed up 👍

Review comments addressed

[ghost]

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!