New Resource: `azurerm_log_analytics_saved_search` #8253

mbfrahry · 2020-08-26T05:47:29Z

Dependent on #8234

--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_complete (139.56s)
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_basic (140.36s)
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_requiresImport (144.51s)

…review/operationalinsights

aristosvo · 2020-08-26T17:23:44Z

Nice, was looking into this but at that time the API wasn’t ready :) Looking forward to use it!

tombuildsstuff

Left some comments inline - but this otherwise LGTM 👍

tombuildsstuff · 2020-08-28T09:55:04Z

azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go

+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: azure.ValidateResourceID,


can we add a more specific parser here to check this is a Log Analytics Workspace ID?

tombuildsstuff · 2020-08-28T09:55:28Z

azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go

+				Type:             schema.TypeString,
+				Required:         true,
+				ForceNew:         true,
+				DiffSuppressFunc: suppress.CaseDifference,


why is this case-insensitive?

Unfortunately, any Log Analytics path doesn't honor casing

Could we open an issue on the SDK and throw in a link here?

tombuildsstuff · 2020-08-28T09:56:15Z

azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go

+		return err
+	}
+
+	if features.ShouldResourcesBeImported() && d.IsNewResource() {


can we remove the call to this deprecated method:

Suggested change

if features.ShouldResourcesBeImported() && d.IsNewResource() {

if d.IsNewResource() {

tombuildsstuff · 2020-08-28T09:57:39Z

azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go

+	}
+
+	if _, err := client.CreateOrUpdate(ctx, id.ResourceGroup, id.Name, name, parameters); err != nil {
+		return err


can we wrap this error:

Suggested change

return err

return fmt.Errorf("creating Saved Search %q (Log Analytics Workspace %q / Resource Group %q): %+v", name, id.Name, id.ResourceGroup, err)

tombuildsstuff · 2020-08-28T09:57:46Z

azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go

+
+	read, err := client.Get(ctx, id.ResourceGroup, id.Name, name)
+	if err != nil {
+		return err


can we wrap this error:

Suggested change

return err

return fmt.Errorf("retrieving Saved Search %q (Log Analytics Workspace %q / Resource Group %q): %+v", name, id.Name, id.ResourceGroup, err)

tombuildsstuff · 2020-08-28T10:01:27Z

azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go

+	}
+
+	_, err = client.Delete(ctx, id.ResourceGroup, id.WorkspaceName, id.Name)
+	if err != nil {


minor we can combine these into a single line

tombuildsstuff · 2020-08-28T10:03:53Z

azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go

+
+	_, err = client.Delete(ctx, id.ResourceGroup, id.WorkspaceName, id.Name)
+	if err != nil {
+		return fmt.Errorf("issuing AzureRM delete request for Log Analytics Saved Search %q (WorkSpace %q / Resource Group %q): %s", id.Name, id.WorkspaceName, id.ResourceGroup, err)


Suggested change

return fmt.Errorf("issuing AzureRM delete request for Log Analytics Saved Search %q (WorkSpace %q / Resource Group %q): %s", id.Name, id.WorkspaceName, id.ResourceGroup, err)

return fmt.Errorf("deleting Saved Search %q (Log Analytics Workspace %q / Resource Group %q): %s", id.Name, id.WorkspaceName, id.ResourceGroup, err)

tombuildsstuff · 2020-08-28T10:06:30Z

website/azurerm.erb

@@ -1903,6 +1903,10 @@
                  <a href="/docs/providers/azurerm/r/log_analytics_linked_service.html">azurerm_log_analytics_linked_service</a>
                </li>

+                <li>
+                  <a href="/docs/providers/azurerm/r/log_analytics_saved_search.html">azurerm_log_analytics_saved_search/a>


Suggested change

<a href="/docs/providers/azurerm/r/log_analytics_saved_search.html">azurerm_log_analytics_saved_search/a>

<a href="/docs/providers/azurerm/r/log_analytics_saved_search.html">azurerm_log_analytics_saved_search</a>

tombuildsstuff · 2020-08-28T10:06:52Z

website/docs/r/log_analytics_saved_search.html.markdown

+
+* `name` - (Required) Specifies the name of the Log Analytics Saved Search. Changing this forces a new resource to be created.
+
+* `log_analytics_workspace_id` - (Required) Specifies the ID of the Log Analytics Work Space that the Saved Search will be associated with. Changing this forces a new resource to be created.


Suggested change

* `log_analytics_workspace_id` - (Required) Specifies the ID of the Log Analytics Work Space that the Saved Search will be associated with. Changing this forces a new resource to be created.

* `log_analytics_workspace_id` - (Required) Specifies the ID of the Log Analytics Workspace that the Saved Search will be associated with. Changing this forces a new resource to be created.

tombuildsstuff · 2020-08-28T10:07:19Z

website/docs/r/log_analytics_saved_search.html.markdown

+
+## Import
+
+Log Analytics Saved Search can be imported using the `resource id`, e.g.


this can be plural:

Suggested change

Log Analytics Saved Search can be imported using the `resource id`, e.g.

Log Analytics Saved Searches can be imported using the `resource id`, e.g.

mbfrahry · 2020-09-01T06:12:22Z

Review addressed!

katbyte

Aside from one comment LGTM 👍

katbyte · 2020-09-01T15:49:53Z

azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go

+				Type:             schema.TypeString,
+				Required:         true,
+				ForceNew:         true,
+				DiffSuppressFunc: suppress.CaseDifference,


Could we open an issue on the SDK and throw in a link here?

ghost · 2020-09-04T03:30:35Z

This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.26.0"
}
# ... other configuration ...

ghost · 2020-10-04T14:51:01Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

mbfrahry added 6 commits August 24, 2020 13:59

Start of loganalytics sdk upgrade

95d3457

Update loganalytics to /preview/operationalinsights/mgmt/2020-03-01-p…

c2d6622

…review/operationalinsights

go mod tidy

fb62217

goimports

0a8272c

goimports

9a54bf2

Start of saved search resource

afa23fd

ghost added size/XXL dependencies labels Aug 26, 2020

Finalizing

881f8fe

mbfrahry changed the title ~~[WIP] New Resource: azurerm_log_analytics_saved_search~~ New Resource: azurerm_log_analytics_saved_search Aug 26, 2020

aristosvo mentioned this pull request Aug 27, 2020

Support for Saved Searches (functions) in Log Analytics workspaces Azure/azure-rest-api-specs#8683

Closed

Merge with master

4e23fad

ghost added size/XL documentation and removed size/XXL labels Aug 27, 2020

Fix comment

7abf149

tombuildsstuff added new-resource service/log-analytics labels Aug 28, 2020

tombuildsstuff suggested changes Aug 28, 2020

View reviewed changes

tombuildsstuff added the waiting-response label Aug 28, 2020

Address review

634799e

mbfrahry removed the waiting-response label Sep 1, 2020

goimports

da6160c

katbyte added this to the v2.26.0 milestone Sep 2, 2020

katbyte approved these changes Sep 2, 2020

View reviewed changes

tombuildsstuff modified the milestones: v2.26.0, v2.27.0 Sep 3, 2020

Address review

ec6eb0e

fmt

d496e6c

mbfrahry merged commit d710350 into master Sep 3, 2020

mbfrahry deleted the f-log-analytics-saved-searche branch September 3, 2020 17:44

mbfrahry added a commit that referenced this pull request Sep 3, 2020

Update changelog for #8253

20b6875

mbfrahry modified the milestones: v2.27.0, v2.26.0 Sep 3, 2020

ghost locked as resolved and limited conversation to collaborators Oct 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_log_analytics_saved_search` #8253

New Resource: `azurerm_log_analytics_saved_search` #8253

mbfrahry commented Aug 26, 2020 •

edited

Loading

aristosvo commented Aug 26, 2020

tombuildsstuff left a comment

tombuildsstuff Aug 28, 2020

tombuildsstuff Aug 28, 2020

mbfrahry Sep 1, 2020

katbyte Sep 1, 2020

tombuildsstuff Aug 28, 2020

tombuildsstuff Aug 28, 2020

tombuildsstuff Aug 28, 2020

tombuildsstuff Aug 28, 2020

tombuildsstuff Aug 28, 2020

tombuildsstuff Aug 28, 2020

tombuildsstuff Aug 28, 2020

tombuildsstuff Aug 28, 2020

mbfrahry commented Sep 1, 2020

katbyte left a comment

katbyte Sep 1, 2020

ghost commented Sep 4, 2020

ghost commented Oct 4, 2020

	if features.ShouldResourcesBeImported() && d.IsNewResource() {
	if d.IsNewResource() {

	return err
	return fmt.Errorf("creating Saved Search %q (Log Analytics Workspace %q / Resource Group %q): %+v", name, id.Name, id.ResourceGroup, err)

	return err
	return fmt.Errorf("retrieving Saved Search %q (Log Analytics Workspace %q / Resource Group %q): %+v", name, id.Name, id.ResourceGroup, err)

	return fmt.Errorf("issuing AzureRM delete request for Log Analytics Saved Search %q (WorkSpace %q / Resource Group %q): %s", id.Name, id.WorkspaceName, id.ResourceGroup, err)
	return fmt.Errorf("deleting Saved Search %q (Log Analytics Workspace %q / Resource Group %q): %s", id.Name, id.WorkspaceName, id.ResourceGroup, err)

	<a href="/docs/providers/azurerm/r/log_analytics_saved_search.html">azurerm_log_analytics_saved_search/a>
	<a href="/docs/providers/azurerm/r/log_analytics_saved_search.html">azurerm_log_analytics_saved_search</a>


		* `name` - (Required) Specifies the name of the Log Analytics Saved Search. Changing this forces a new resource to be created.

		* `log_analytics_workspace_id` - (Required) Specifies the ID of the Log Analytics Work Space that the Saved Search will be associated with. Changing this forces a new resource to be created.


		## Import

		Log Analytics Saved Search can be imported using the `resource id`, e.g.

	Log Analytics Saved Search can be imported using the `resource id`, e.g.
	Log Analytics Saved Searches can be imported using the `resource id`, e.g.

New Resource: azurerm_log_analytics_saved_search #8253

New Resource: azurerm_log_analytics_saved_search #8253

Conversation

mbfrahry commented Aug 26, 2020 • edited Loading

aristosvo commented Aug 26, 2020

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbfrahry commented Sep 1, 2020

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Sep 4, 2020

ghost commented Oct 4, 2020

New Resource: `azurerm_log_analytics_saved_search` #8253

New Resource: `azurerm_log_analytics_saved_search` #8253

mbfrahry commented Aug 26, 2020 •

edited

Loading