add doc and test to support function app slot vnet connetion - "azurerm_app_service_slot_virtual_network_swift_connection" #8111
Conversation
njuCZ
changed the title
There was a problem hiding this comment.
hey @njuCZ
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can handle the errors here then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/web/resource_arm_app_service_slot_virtual_network_swift_connection.go
Outdated
Show resolved
Hide resolved
|
|
||
| * `slot_name` - (Required) The name of the App Service Slot. Changing this forces a new resource to be created. | ||
| * `slot_name` - (Required) The name of the App Service Slot or Function App Slot. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
whilst these are shared today - longer-term we'll likely want to introduce an alias for the function app resources
this isn't a big deal right now, and these do technically work - but we'll probably look to add aliases for these resources in 3.0 - since (based on Github issues) folks appear to be unaware these are the same thing
|
@tombuildsstuff I have added back the error check, could you please have a look again? |
|
Tests pass:
|
|
This has been released in version 2.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.25.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
fix #8048
because app service and function app are one rest api, resource "azurerm_app_service_slot_virtual_network_swift_connection" also applies to "azurerm_function_app_slot". this PR add test and doc for function app part