Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_mariadb_virtual_network_rule - Remove subnet endpoint check #8100

Merged
merged 2 commits into from
Aug 12, 2020
Merged

azurerm_mariadb_virtual_network_rule - Remove subnet endpoint check #8100

merged 2 commits into from
Aug 12, 2020

Conversation

anttisiiskonen
Copy link
Contributor

Fixes #8080.

@ghost ghost added the size/S label Aug 12, 2020
@katbyte katbyte added this to the v2.23.0 milestone Aug 12, 2020
katbyte
katbyte approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anttisiiskonen - LGTM 👍

@katbyte katbyte merged commit c5e84be into hashicorp:master Aug 12, 2020
@katbyte katbyte changed the title Remove mariadb virtual network rule subnet endpoint check azurerm_mariadb_virtual_network_rule - Remove subnet endpoint check Aug 12, 2020
katbyte added a commit that referenced this pull request Aug 12, 2020
@katbyte
update CHANGELOG.md for #8100
3574bb6
@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug service/mariadb size/S
Projects
None yet
Milestone
v2.23.0
Development

Successfully merging this pull request may close these issues.

azurerm_mariadb_virtual_network_rule doesn't work cross-subscription
2 participants
@anttisiiskonen @katbyte