-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_hpc_cache: update API version to 2020-03-01 and support mtu
and root_squash_enabled
properties
#8078
Conversation
…rk/security settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @magodo - overall looks good but we need the docs updated
@katbyte I have added the document and passed the CI, please continue reviewing 👀 |
@katbyte I have resolved the conflicts, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo - no a couple test failures that once addressed this should be good to merge:
------- Stdout: -------
=== RUN TestAccAzureRMHPCCacheBlobTarget_basic
=== PAUSE TestAccAzureRMHPCCacheBlobTarget_basic
=== CONT TestAccAzureRMHPCCacheBlobTarget_basic
TestAccAzureRMHPCCacheBlobTarget_basic: testing.go:684: Step 1 error: HPC Cache Target "acctest-HPCCTGT-bo6cv" (Resource Group "acctestRG-storage-200925202505000834", Cahe "acctest-HPCC-200925202505000834") "type" mismatch, expected "clfs", got "Microsoft.StorageCache/caches/storageTargets"
--- FAIL: TestAccAzureRMHPCCacheBlobTarget_basic (1696.69s)
FAIL
------- Stdout: -------
=== RUN TestAccAzureRMHPCCacheBlobTarget_update
=== PAUSE TestAccAzureRMHPCCacheBlobTarget_update
=== CONT TestAccAzureRMHPCCacheBlobTarget_update
TestAccAzureRMHPCCacheBlobTarget_update: testing.go:684: Step 1 error: HPC Cache Target "acctest-HPCCTGT-pcwmf" (Resource Group "acctestRG-storage-200925202504964363", Cahe "acctest-HPCC-200925202504964363") "type" mismatch, expected "clfs", got "Microsoft.StorageCache/caches/storageTargets"
--- FAIL: TestAccAzureRMHPCCacheBlobTarget_update (1758.40s)
FAIL
Hi @katbyte I have removed the importer where the error derived from, since the Read callback has already handle incorrect import. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo - LGTM 👍
mtu
and root_squash_enabled
properties
This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.30.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Update API version of storagecache from 2019-11-01 to 2020-03-01, which supports network/security settings for hpc cache.
Meanwhile, the model of hpc cache target (nfs/cls) are changed into using discriminator. Hence those files are also modified to compile.
There should be no breaking change introduced by this PR.
(fixes #8021)