Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VM stopping/deallocating before updating. #8000

Merged

Conversation

NilsBusche
Copy link
Contributor

@NilsBusche NilsBusche commented Aug 4, 2020

This improves stopping and deallocating VMs before starting the update.

For update actions where a stopped or deallocated VM is needed, now the stop and deallocation operation only are triggered, if the VM is not already stopped/deallocated.

This fixes problems mentioned in #6880

Fixes #6880

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @NilsBusche 👍

@tombuildsstuff
Copy link
Contributor

Ran the test suite and this looks fine 👍

@tombuildsstuff tombuildsstuff merged commit 95c76e6 into hashicorp:master Aug 10, 2020
tombuildsstuff added a commit that referenced this pull request Aug 10, 2020
@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_linux_virtual_machine: Change of vm_size discards deallocated state
2 participants