Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service refactor and feature alignment #7945

Merged
merged 17 commits into from
Aug 11, 2020

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Jul 29, 2020

Changes:

  • Data Source: azurerm_app_service now exports source_control configuration

  • Data Source: azurerm_function_app now exports source_control configuration

  • Data Source: azurerm_function_app now exports site_config configuration

  • azurerm_app_service now supports source_control configuration

  • azurerm_function_app now supports source_control configuration

  • azurerm_function_app now supports full ip_restriction configuration

  • azurerm_function_app now supports full scm_ip_restriction configuration

@jackofallops jackofallops force-pushed the f/app-service-source-control branch from 59c6cab to 3f02836 Compare July 30, 2020 09:07
@jackofallops jackofallops marked this pull request as ready for review August 5, 2020 15:29
@jackofallops jackofallops requested a review from a team August 5, 2020 15:29
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a few comments LGTM 👍

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.23.0 milestone Aug 11, 2020
@jackofallops jackofallops merged commit 9166bb5 into master Aug 11, 2020
@jackofallops jackofallops deleted the f/app-service-source-control branch August 11, 2020 10:02
jackofallops added a commit that referenced this pull request Aug 11, 2020
@jackofallops
Copy link
Member Author

Tests Passing:
image
Failures transient

@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants