Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service_plan - update the relation between kind and reserved #7943

Merged
merged 3 commits into from
Jul 29, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jul 29, 2020

revert PR #7661
correctly fix #2840
fix #7759

I have emailed the service team:
kind is just an ARM level property that is used primarily to drive UX – i.e. what kind of icons or text to show.
reserved is the field to control whether the compute resource is linux or windows.

So when creating an app service plan.
if we choose "windows" as kind, the reserved should be false
if we choose "linux" as kind, the reserved should be true
for other type of kind, users may choose windows or linux

The original document is right

image

@njuCZ njuCZ changed the title revert update the relation between type and reserved - "azurerm_app_service_plan" Jul 29, 2020
@ghost ghost added size/S and removed size/XS labels Jul 29, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title update the relation between type and reserved - "azurerm_app_service_plan" azurerm_app_service_plan - update the relation between kind and reserved Jul 29, 2020
@mbfrahry mbfrahry added this to the v2.21.0 milestone Jul 29, 2020
@mbfrahry mbfrahry merged commit e92534e into hashicorp:master Jul 29, 2020
mbfrahry added a commit that referenced this pull request Jul 29, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 2.21.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.21.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants