Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_monitor_autoscale_settings support for time_aggregation = "Last" #7480

Merged
merged 1 commit into from
Jun 25, 2020
Merged

azurerm_monitor_autoscale_settings support for time_aggregation = "Last" #7480

merged 1 commit into from
Jun 25, 2020

Conversation

SebRosander
Copy link
Contributor

Fixes #3328

@ghost ghost added the size/XS label Jun 24, 2020
katbyte
katbyte previously requested changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @SebRosander, could we update the docs with the new value? thanks 🙂

@SebRosander
Copy link
Contributor Author

Hi @katbyte
It’s already in the docs. This just fixes the actual support for it 😅😉

@SebRosander SebRosander requested a review from katbyte June 25, 2020 05:27
tombuildsstuff
tombuildsstuff approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @SebRosander

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review June 25, 2020 13:03

dismissing since this is already in the docs

@tombuildsstuff tombuildsstuff added this to the v2.16.0 milestone Jun 25, 2020
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-06-25 at 15 26 24

@tombuildsstuff tombuildsstuff merged commit 83832c6 into hashicorp:master Jun 25, 2020
tombuildsstuff added a commit that referenced this pull request Jun 25, 2020
@tombuildsstuff
updating to include #7480
44a6cff
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@tombuildsstuff @jrauschenbusch
updating to include hashicorp#7480
003acbe
@ghost
Copy link

ghost commented Jul 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
enhancement service/monitor size/XS
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging this pull request may close these issues.

Got Error which is inconsistent with documentation in autoscale setting configuration
3 participants
@SebRosander @tombuildsstuff @katbyte