Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update scenario for network interface #6624

Merged
merged 22 commits into from
May 6, 2020

Conversation

neil-yechenwei
Copy link
Contributor

fixes #6546

The update API of network interface is full update not incremental update.

neil-yechenwei and others added 21 commits April 23, 2020 10:18
* Add support for tags of private endpoint

* Fix test issue

Co-authored-by: Jeffrey Cline <[email protected]>
…pt all valid IPv4 address ranges (hashicorp#6589)

* Update prefix length validation

* Updated documentation for new ranges

* Add test and change upper limit to 31

* Update error msgs to be go compliant

* Add note to test case about subscription config
Updating instead of foo to example -code correction
Comment on lines 514 to 517
dns_servers = [
"10.0.0.5",
"10.0.0.6"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked issue refers to changing DNS servers, but these stay the same through the update test, should we be testing/validating this in the update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@neil-yechenwei
Copy link
Contributor Author

@jackofallops , thanks for your comments. I've updated code.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @neil-yechenwei
Thanks for this, looks good to me 👍

Ste

@jackofallops
Copy link
Member

Tests pass:
image

@jackofallops jackofallops added this to the v2.9.0 milestone May 6, 2020
@jackofallops jackofallops merged commit c441e85 into hashicorp:master May 6, 2020
jackofallops added a commit that referenced this pull request May 6, 2020
@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_network_interface setting dns_servers removes tags
8 participants